Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 14125: fix box shadows (Closed)

Created:
12 years ago by tony
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

fix box shadows We need to apply the context transform to the shadow before rendering it. There's also a weird case where we have to flip the y offset if we're not applying the transform. I'm not sure why this is necessary, but it allows us to pass canvas-shadow tests. BUG=5503

Patch Set 1 #

Patch Set 2 : reflow #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -318 lines) Patch
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/box-shadow/border-radius-big-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/box-shadow/border-radius-big-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/box-shadow/border-radius-big-expected.txt View 1 chunk +13 lines, -13 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-dynamic-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-dynamic-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-dynamic-expected.txt View 1 chunk +14 lines, -14 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-h-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-h-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-h-expected.txt View 1 chunk +139 lines, -139 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-v-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-v-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/box-shadow-v-expected.txt View 1 chunk +139 lines, -139 lines 0 comments Download
M webkit/port/platform/graphics/skia/GraphicsContextSkia.cpp View 1 1 chunk +26 lines, -5 lines 1 comment Download
M webkit/tools/layout_tests/test_lists/tests_fixable.txt View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
12 years ago (2008-12-15 19:55:26 UTC) #1
brettw
LGTM http://codereview.chromium.org/14125/diff/215/28 File webkit/port/platform/graphics/skia/GraphicsContextSkia.cpp (right): http://codereview.chromium.org/14125/diff/215/28#newcode952 Line 952: double eigenvalue = sqrt(0.5 * ((a + ...
12 years ago (2008-12-15 19:58:49 UTC) #2
tony
12 years ago (2008-12-15 20:31:09 UTC) #3
On 2008/12/15 19:58:49, brettw wrote:
> LGTM
> 
> http://codereview.chromium.org/14125/diff/215/28
> File webkit/port/platform/graphics/skia/GraphicsContextSkia.cpp (right):
> 
> http://codereview.chromium.org/14125/diff/215/28#newcode952
> Line 952: double eigenvalue = sqrt(0.5 * ((a + d) - sqrt(4 * b * c + (a - d) *
> (a - d))));
> Eigenvalues... hard core!

I'm just copying code from the CG port :)

Powered by Google App Engine
This is Rietveld 408576698