Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 141056: x64: Generate code for loading from, storing to and calling properties. (Closed)

Created:
11 years, 6 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

x64: Generate code for loading from, storing to and calling properties. Committed: http://code.google.com/p/v8/source/detail?r=2245

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -162 lines) Patch
M src/ia32/ic-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ic.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/x64/codegen-x64.cc View 8 chunks +255 lines, -144 lines 1 comment Download
M src/x64/frames-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/x64/ic-x64.cc View 3 chunks +115 lines, -3 lines 0 comments Download
M src/x64/virtual-frame-x64.cc View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 6 months ago (2009-06-22 19:40:38 UTC) #1
William Hesse
11 years, 6 months ago (2009-06-22 21:31:29 UTC) #2
LGTM.

http://codereview.chromium.org/141056/diff/1/8
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/141056/diff/1/8#newcode181
Line 181: "  o[f_string]();"
Now that if ... then is working, we can check all tests by something like
final_check = 1;
if (test_feature(1,2,3)) { x = x; } else { final_check = 0; }

...
return final_check;

Powered by Google App Engine
This is Rietveld 408576698