Issue 141043: X64 implementation: Emit correct merge code for virtual frames at CFG merges.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141043: X64 implementation: Emit correct merge code for virtual frames at CFG merges. (Closed)

Created:
11 years, 6 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64 implementation: Emit correct merge code for virtual frames at CFG merges. Committed: http://code.google.com/p/v8/source/detail?r=2238

Patch Set 1 #

Total comments: 4

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+311 lines, -38 lines)			Patch
M	src/ia32/virtual-frame-ia32.cc	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	2 chunks	+12 lines, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	src/x64/virtual-frame-x64.cc	View	3 chunks	+244 lines, -30 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/141043/diff/1/5 File src/x64/virtual-frame-x64.cc (right): http://codereview.chromium.org/141043/diff/1/5#newcode436 Line 436: elements_[i].set_static_type(element.static_type()); This has changed in ia32 (to ...

11 years, 6 months ago (2009-06-22 12:43:27 UTC) #2

William Hesse

11 years, 6 months ago (2009-06-22 14:33:40 UTC) #3

http://codereview.chromium.org/141043/diff/1/5
File src/x64/virtual-frame-x64.cc (right):

http://codereview.chromium.org/141043/diff/1/5#newcode436
Line 436: elements_[i].set_static_type(element.static_type());
On 2009/06/22 12:43:27, Lasse Reichstein wrote:
> This has changed in ia32 (to setting the type to StaticType::unknown()).
Should
> change here too (and you'll get a conflict in ia32 code).

Done.

http://codereview.chromium.org/141043/diff/1/5#newcode622
Line 622: Operand(rbp, fp_relative(backing_index)));
On 2009/06/22 12:43:27, Lasse Reichstein wrote:
> Indentation.
> 

Done.

Expand Messages | Collapse Messages