Chromium Code Reviews

Issue 141042: Fix regexp bug reported on iit.edu. (Closed)

Created:
11 years, 6 months ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Fix regexp bug reported on iit.edu. Committed: http://code.google.com/p/v8/source/detail?r=2235

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+37 lines, -3 lines)
M src/jsregexp.cc View 2 chunks +6 lines, -3 lines 1 comment
A test/mjsunit/regexp-captures.js View 1 chunk +31 lines, -0 lines 0 comments

Messages

Total messages: 3 (0 generated)
Erik Corry
11 years, 6 months ago (2009-06-22 12:06:25 UTC) #1
Lasse Reichstein
LGTM
11 years, 6 months ago (2009-06-22 12:27:59 UTC) #2
Lasse Reichstein
11 years, 6 months ago (2009-06-22 12:32:48 UTC) #3
LGTM

http://codereview.chromium.org/141042/diff/6/1004
File src/jsregexp.cc (right):

http://codereview.chromium.org/141042/diff/6/1004#newcode408
Line 408: (IrregexpNumberOfCaptures(FixedArray::cast(jsregexp->data())) + 1) * 2
:
Seems this have different meanings for the two implementations.
For native irregexp, it really is number of *capture* registers, but for the
interpreter it is number of registers total.
How about moving it into the branches of the conditional, so each branch can
have its own code (and properly named variables).

Powered by Google App Engine