Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 141041: Do not fail on matching breakpoint against snippet with incompatible line range. (Closed)

Created:
11 years, 6 months ago by yurys
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

After compile event should be sent even if there is a provisional breakpoint out of its lines range. Committed: http://code.google.com/p/v8/source/detail?r=2234

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M src/debug-delay.js View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
11 years, 6 months ago (2009-06-22 11:31:48 UTC) #1
pfeldman
LGTM, but please wait for the official one from Soren :)
11 years, 6 months ago (2009-06-22 11:36:36 UTC) #2
Søren Thygesen Gjesse
LGTM Thank you for fixing this. http://codereview.chromium.org/141041/diff/1/2 File test/cctest/test-debug.cc (right): http://codereview.chromium.org/141041/diff/1/2#newcode5263 Line 5263: // breakpoints ...
11 years, 6 months ago (2009-06-22 11:46:48 UTC) #3
yurys
11 years, 6 months ago (2009-06-22 11:52:50 UTC) #4
http://codereview.chromium.org/141041/diff/1/2
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/141041/diff/1/2#newcode5263
Line 5263: // breakpoints out of the scrit lines range.
On 2009/06/22 11:46:48, Søren Gjesse wrote:
> scrit -> scripts

Done.

Powered by Google App Engine
This is Rietveld 408576698