X64: Enable lazy compilation and add code generation for simple object...

X64: Enable lazy compilation and add code generation for simple object
literals.

Committed: http://code.google.com/p/v8/source/detail?r=2232

[William Hesse, 2009-06-22 10:25:31]

LGTM.

http://codereview.chromium.org/141040/diff/1/4
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/141040/diff/1/4#newcode42
Line 42: #define __ ACCESS_MASM(masm_)
At the bottom of this file, beneath CodeGen implementation, there is a section
of stubs and deferred code generation, with the correct define of __.  If these
go there, then __ is defined correctly already.

http://codereview.chromium.org/141040/diff/1/2
File src/x64/stub-cache-x64.cc (right):

http://codereview.chromium.org/141040/diff/1/2#newcode125
Line 125: #define __ ACCESS_MASM(masm())
Should this go at the top of the file?

http://codereview.chromium.org/141040/diff/1/2#newcode139
Line 139: __ pop(rdi);
Could pop(rdi) be commented, explaining why it is needed and what it
accomplishes?

[William Hesse, 2009-06-22 10:31:35]

http://codereview.chromium.org/141040/diff/10/13
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/141040/diff/10/13#newcode161
Line 161: "  var o = { x: x_value };"
Why isn't this hitting the unimplemented  
case ObjectLiteral::Property::COMPUTED:
in the object from boilerplate code?

[Mads Ager (chromium), 2009-06-22 10:51:05]

http://codereview.chromium.org/141040/diff/1/2
File src/x64/stub-cache-x64.cc (right):

http://codereview.chromium.org/141040/diff/1/2#newcode125
Line 125: #define __ ACCESS_MASM(masm())
On 2009/06/22 10:25:31, William Hesse wrote:
> Should this go at the top of the file?

Done.

http://codereview.chromium.org/141040/diff/10/13
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/141040/diff/10/13#newcode161
Line 161: "  var o = { x: x_value };"
On 2009/06/22 10:31:35, William Hesse wrote:
> Why isn't this hitting the unimplemented  
> case ObjectLiteral::Property::COMPUTED:
> in the object from boilerplate code?

It is, accidentally uploaded this instead of just 'var o = { x: 42 }'.  Fixed.

[Mads Ager (chromium), 2009-06-22 10:52:41]

http://codereview.chromium.org/141040/diff/1/4
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/141040/diff/1/4#newcode42
Line 42: #define __ ACCESS_MASM(masm_)
On 2009/06/22 10:25:31, William Hesse wrote:
> At the bottom of this file, beneath CodeGen implementation, there is a section
> of stubs and deferred code generation, with the correct define of __.  If
these
> go there, then __ is defined correctly already.

I'm keeping the order to match the ia32 order of methods.  Extending the scope
instead (removing '#undef __' and the next '#define __ ...'.