Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 141040: X64: Enable lazy compilation and add code generation for simple object... (Closed)

Created:
11 years, 6 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

X64: Enable lazy compilation and add code generation for simple object literals. Committed: http://code.google.com/p/v8/source/detail?r=2232

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -10 lines) Patch
M src/x64/codegen-x64.cc View 1 4 chunks +156 lines, -5 lines 2 comments Download
M src/x64/codegen-x64-inl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +27 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mads Ager (chromium)
11 years, 6 months ago (2009-06-22 09:13:31 UTC) #1
William Hesse
LGTM. http://codereview.chromium.org/141040/diff/1/4 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/141040/diff/1/4#newcode42 Line 42: #define __ ACCESS_MASM(masm_) At the bottom of ...
11 years, 6 months ago (2009-06-22 10:25:31 UTC) #2
William Hesse
http://codereview.chromium.org/141040/diff/10/13 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/141040/diff/10/13#newcode161 Line 161: " var o = { x: x_value };" ...
11 years, 6 months ago (2009-06-22 10:31:35 UTC) #3
Mads Ager (chromium)
http://codereview.chromium.org/141040/diff/1/2 File src/x64/stub-cache-x64.cc (right): http://codereview.chromium.org/141040/diff/1/2#newcode125 Line 125: #define __ ACCESS_MASM(masm()) On 2009/06/22 10:25:31, William Hesse ...
11 years, 6 months ago (2009-06-22 10:51:05 UTC) #4
Mads Ager (chromium)
11 years, 6 months ago (2009-06-22 10:52:41 UTC) #5
http://codereview.chromium.org/141040/diff/1/4
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/141040/diff/1/4#newcode42
Line 42: #define __ ACCESS_MASM(masm_)
On 2009/06/22 10:25:31, William Hesse wrote:
> At the bottom of this file, beneath CodeGen implementation, there is a section
> of stubs and deferred code generation, with the correct define of __.  If
these
> go there, then __ is defined correctly already.

I'm keeping the order to match the ia32 order of methods.  Extending the scope
instead (removing '#undef __' and the next '#define __ ...'.

Powered by Google App Engine
This is Rietveld 408576698