Issue 141038: Implemented a ContextSlotCache for compiled code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141038: Implemented a ContextSlotCache for compiled code. (Closed)

Created:
11 years, 6 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (google), Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Implemented a ContextSlotCache for compiled code. Committed: http://code.google.com/p/v8/source/detail?r=2230

Patch Set 1 #

Total comments: 5

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+174 lines, -17 lines)			Patch
M	src/contexts.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.h	View	2 chunks	+10 lines, -11 lines	1 comment	Download
M	src/heap.cc	View	4 chunks	+8 lines, -0 lines	1 comment	Download
M	src/runtime.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/scopeinfo.h	View	1 chunk	+69 lines, -0 lines	2 comments	Download
M	src/scopeinfo.cc	View	3 chunks	+84 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 6 months ago (2009-06-22 08:00:18 UTC) #2

LGTM

http://codereview.chromium.org/141038/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/141038/diff/1/2#newcode3521
Line 3521: // ------ KeyedLookupCache ------
We do not have separators like this in the rest of the code.  Could you remove
it (or add in more so it is consistently used)?

http://codereview.chromium.org/141038/diff/1/6
File src/heap.h (right):

http://codereview.chromium.org/141038/diff/1/6#newcode976
Line 976: inline static void CopyBlock(Object** dst, Object** src, int
byte_size);
This is not your code, but could you make this 'static inline' to match the
rest?

http://codereview.chromium.org/141038/diff/1/7
File src/scopeinfo.cc (right):

http://codereview.chromium.org/141038/diff/1/7#newcode428
Line 428: 
Remove extra lines.

http://codereview.chromium.org/141038/diff/1/5
File src/scopeinfo.h (right):

http://codereview.chromium.org/141038/diff/1/5#newcode168
Line 168: // slot index -1 means the property is absent.
Capitalize 'Slot'?

http://codereview.chromium.org/141038/diff/1/5#newcode193
Line 193: static void Check(Code* code,
Use a more telling name such as 'IsValidEntry'?

Expand Messages | Collapse Messages