Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: chrome/browser/browser_focus_uitest.cc

Issue 141013: Relanding focus manager refactoring (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/external_tab_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_focus_uitest.cc
===================================================================
--- chrome/browser/browser_focus_uitest.cc (revision 18879)
+++ chrome/browser/browser_focus_uitest.cc (working copy)
@@ -108,7 +108,7 @@
BrowserView* browser_view = BrowserView::GetBrowserViewForNativeWindow(hwnd);
ASSERT_TRUE(browser_view);
views::FocusManager* focus_manager =
- views::FocusManager::GetFocusManager(hwnd);
+ views::FocusManager::GetFocusManagerForNativeView(hwnd);
ASSERT_TRUE(focus_manager);
EXPECT_EQ(browser_view->GetTabContentsContainerView(),
@@ -149,7 +149,7 @@
BrowserView::GetBrowserViewForNativeWindow(hwnd2);
ASSERT_TRUE(browser_view2);
views::FocusManager* focus_manager2 =
- views::FocusManager::GetFocusManager(hwnd2);
+ views::FocusManager::GetFocusManagerForNativeView(hwnd2);
ASSERT_TRUE(focus_manager2);
EXPECT_EQ(browser_view2->GetTabContentsContainerView(),
focus_manager2->GetFocusedView());
@@ -183,13 +183,13 @@
ASSERT_TRUE(browser_view);
views::FocusManager* focus_manager =
- views::FocusManager::GetFocusManager(hwnd);
+ views::FocusManager::GetFocusManagerForNativeView(hwnd);
ASSERT_TRUE(focus_manager);
// Create several tabs.
for (int i = 0; i < 4; ++i) {
- browser()->AddTabWithURL(url, GURL(), PageTransition::TYPED, true, -1, false,
- NULL);
+ browser()->AddTabWithURL(url, GURL(), PageTransition::TYPED, true, -1,
+ false, NULL);
}
// Alternate focus for the tab.
@@ -283,7 +283,7 @@
HWND hwnd = reinterpret_cast<HWND>(browser()->window()->GetNativeHandle());
BrowserView* browser_view = BrowserView::GetBrowserViewForNativeWindow(hwnd);
views::FocusManager* focus_manager =
- views::FocusManager::GetFocusManager(hwnd);
+ views::FocusManager::GetFocusManagerForNativeView(hwnd);
// Click on the location bar.
LocationBarView* location_bar = browser_view->GetLocationBarView();
@@ -311,7 +311,7 @@
HWND hwnd = reinterpret_cast<HWND>(browser()->window()->GetNativeHandle());
BrowserView* browser_view = BrowserView::GetBrowserViewForNativeWindow(hwnd);
views::FocusManager* focus_manager =
- views::FocusManager::GetFocusManager(hwnd);
+ views::FocusManager::GetFocusManagerForNativeView(hwnd);
// Click on the location bar.
LocationBarView* location_bar = browser_view->GetLocationBarView();
@@ -401,7 +401,7 @@
HWND hwnd = reinterpret_cast<HWND>(browser()->window()->GetNativeHandle());
BrowserView* browser_view = BrowserView::GetBrowserViewForNativeWindow(hwnd);
views::FocusManager* focus_manager =
- views::FocusManager::GetFocusManager(hwnd);
+ views::FocusManager::GetFocusManagerForNativeView(hwnd);
// Focus should be on the page.
EXPECT_EQ(browser_view->GetTabContentsContainerView(),
@@ -496,7 +496,7 @@
HWND hwnd = reinterpret_cast<HWND>(browser()->window()->GetNativeHandle());
BrowserView* browser_view = BrowserView::GetBrowserViewForNativeWindow(hwnd);
views::FocusManager* focus_manager =
- views::FocusManager::GetFocusManager(hwnd);
+ views::FocusManager::GetFocusManagerForNativeView(hwnd);
// Page should have focus.
EXPECT_EQ(browser_view->GetTabContentsContainerView(),
@@ -541,7 +541,7 @@
HWND hwnd = reinterpret_cast<HWND>(browser()->window()->GetNativeHandle());
BrowserView* browser_view = BrowserView::GetBrowserViewForNativeWindow(hwnd);
views::FocusManager* focus_manager =
- views::FocusManager::GetFocusManager(hwnd);
+ views::FocusManager::GetFocusManagerForNativeView(hwnd);
LocationBarView* location_bar = browser_view->GetLocationBarView();
// Press Ctrl+F, which will make the Find box open and request focus.
@@ -613,7 +613,7 @@
BrowserView* browser_view = BrowserView::GetBrowserViewForNativeWindow(hwnd);
ASSERT_TRUE(browser_view);
views::FocusManager* focus_manager =
- views::FocusManager::GetFocusManager(hwnd);
+ views::FocusManager::GetFocusManagerForNativeView(hwnd);
ASSERT_TRUE(focus_manager);
// Open the history tab, focus should be on the tab contents.
« no previous file with comments | « chrome/browser/automation/automation_provider.cc ('k') | chrome/browser/external_tab_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698