Issue 14073: Implement the memory mapped file class for posix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14073: Implement the memory mapped file class for posix. (Closed)

Created:
12 years ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tommi (sloooow) - chröme, brettw, Peter Kasting

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implement the memory mapped file class for posix. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6935

Patch Set 1 #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -27 lines)			Patch
M	base/file_util.h	View	3 chunks	+8 lines, -6 lines	0 comments	Download
M	base/file_util.cc	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	base/file_util_posix.cc	View	3 chunks	+40 lines, -0 lines	1 comment	Download
M	base/file_util_win.cc	View	2 chunks	+0 lines, -20 lines	0 comments	Download
M	chrome/browser/spellchecker.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

Follow up to http://codereview.chromium.org/14041/show . Includes Brett's capitalization changes.

12 years ago (2008-12-12 21:23:10 UTC) #1

Peter Kasting

LGTM http://codereview.chromium.org/14073/diff/1/4 File base/file_util_posix.cc (right): http://codereview.chromium.org/14073/diff/1/4#newcode505 Line 505: data_ = static_cast<uint8*>(mmap(NULL, length_, PROT_READ, MAP_SHARED, Super-tiny ...

12 years ago (2008-12-12 21:27:49 UTC) #3

tommi (sloooow) - chröme

12 years ago (2008-12-12 21:45:59 UTC) #4

LGTM - sorry I lgtm-ed the other change again by mistake :)

Expand Messages | Collapse Messages