Issue 14071: Make all GRIT placeholders only use caps and underscores....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14071: Make all GRIT placeholders only use caps and underscores.... (Closed)

Created:
12 years ago by tony

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/chrome/app/

Visibility:
Public.

Description

Make all GRIT placeholders only use caps and underscores. The translation console only knows how to handle CAPS and underscores for placeholders. There's a check in the GRIT code that verifies this when we generate the translation console upload format. But we never go through this code path when generating the .rc and .h files. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6934

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	generated_resources.grd	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sorry about that.

LGTM

Expand Messages | Collapse Messages