chrome/browser/download/download_item.cc - Issue 1403001: Modifying the "dangerous download" algorithm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_item.cc

Issue 1403001: Modifying the "dangerous download" algorithm. (Closed)

Patch Set: Removing unnecessary namespace qualifier Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_item.cc

diff --git a/chrome/browser/download/download_item.cc b/chrome/browser/download/download_item.cc

index 3069e94802702bdf2b16a38f803414cac164c9e7..e61d4ca3ecdd60cf3e9fba89d1dcf41cf2ec93f0 100644

--- a/chrome/browser/download/download_item.cc

+++ b/chrome/browser/download/download_item.cc

@@ -164,7 +164,7 @@ void DownloadItem::NotifyObserversDownloadFileCompleted() {

bool DownloadItem::CanOpenDownload() {

return !Extension::IsExtension(target_name_) &&

- !download_util::IsExecutableFile(target_name_);

+ download_util::IsFileSafe(target_name_);

}

bool DownloadItem::ShouldOpenFileBasedOnExtension() {