Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 140068: Implement code generation for conditional expressions and regexp... (Closed)

Created:
11 years, 6 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Implement code generation for conditional expressions and regexp literals. Regexp literals will not really work before we can bootstrap, but the right code is being called with the right arguments. Finish implementation of object literals. We can now call through the StoreIC_Miss stub into the runtime system to do stores. Restore comment that I accidentally removed in my last commit. Committed: http://code.google.com/p/v8/source/detail?r=2244

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -26 lines) Patch
M src/x64/codegen-x64.cc View 1 6 chunks +124 lines, -9 lines 0 comments Download
M src/x64/frames-x64.cc View 1 chunk +30 lines, -9 lines 0 comments Download
M src/x64/ic-x64.cc View 3 chunks +25 lines, -1 line 2 comments Download
M src/x64/register-allocator-x64.cc View 1 1 chunk +11 lines, -7 lines 2 comments Download
M src/x64/virtual-frame-x64.cc View 1 chunk +29 lines, -0 lines 6 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
11 years, 6 months ago (2009-06-22 15:37:59 UTC) #1
William Hesse
LGTM. http://codereview.chromium.org/140068/diff/1007/14 File src/x64/ic-x64.cc (right): http://codereview.chromium.org/140068/diff/1007/14#newcode188 Line 188: // -- rsp[4] : receiver rsp[8]? http://codereview.chromium.org/140068/diff/1007/15 ...
11 years, 6 months ago (2009-06-22 19:14:23 UTC) #2
Mads Ager (chromium)
11 years, 6 months ago (2009-06-22 19:25:00 UTC) #3
http://codereview.chromium.org/140068/diff/1007/14
File src/x64/ic-x64.cc (right):

http://codereview.chromium.org/140068/diff/1007/14#newcode188
Line 188: //  -- rsp[4] : receiver
On 2009/06/22 19:14:23, William Hesse wrote:
> rsp[8]?

Done.

http://codereview.chromium.org/140068/diff/1007/15
File src/x64/register-allocator-x64.cc (right):

http://codereview.chromium.org/140068/diff/1007/15#newcode50
Line 50: RelocInfo::NONE);
On 2009/06/22 19:14:23, William Hesse wrote:
> Could you say
> CodeGeneratorScope::Current()->masm()->Move(fresh.reg(), handle()), or is
there
> no way to access the masm?
> 
> 

Done.  And also done for the same piece of code below.

http://codereview.chromium.org/140068/diff/1007/13
File src/x64/virtual-frame-x64.cc (right):

http://codereview.chromium.org/140068/diff/1007/13#newcode862
Line 862: // expects name in ecx, value in eax, and receiver on the stack.  It
On 2009/06/22 19:14:23, William Hesse wrote:
> rcx, value in rax, 

Done.

http://codereview.chromium.org/140068/diff/1007/13#newcode874
Line 874: // Register eax is free for value, which frees ecx for name.
On 2009/06/22 19:14:23, William Hesse wrote:
> Register rax ... rcx

Done.

http://codereview.chromium.org/140068/diff/1007/13#newcode879
Line 879: // Register ecx is free for name, which guarantees eax is free for
On 2009/06/22 19:14:23, William Hesse wrote:
> rcx ... rax

Done.

Powered by Google App Engine
This is Rietveld 408576698