Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 140064: Revert :... (Closed)

Created:
11 years, 6 months ago by Nicolas Sylvain
Modified:
9 years, 7 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com, darin (slow to review), Ben Goodger (Google)
Visibility:
Public.

Description

Revert : Changed by: jcampan@chromium.org Changed at: Fri 19 Jun 2009 21:22:47 Branch: src Revision: 18889 Comments: Relanding focus manager refactoring with build fix, see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben Review URL: http://codereview.chromium.org/141013 Because it creates hundreds of new reliability crashes. TBR:jcampan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -221 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/external_tab_container.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/first_run_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/autocomplete/autocomplete_popup_win.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/views/blocked_popup_container_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bubble_view.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/views/browser_bubble_win.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/views/constrained_window_win.cc View 1 chunk +36 lines, -1 line 0 comments Download
M chrome/browser/views/download_started_animation_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/find_bar_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/views/find_bar_win_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/views/first_run_bubble.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/views/fullscreen_exit_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/info_bubble.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/views/infobars/infobars.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/views/shelf_item_dialog.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/status_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_win.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/views/tabs/dragged_tab_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/dragged_tab_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/native_view_photobooth_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 1 chunk +2 lines, -1 line 0 comments Download
M views/controls/menu/chrome_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/native_control.cc View 1 chunk +2 lines, -1 line 0 comments Download
M views/controls/native_control_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M views/controls/tabbed_pane.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/textfield/native_textfield_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M views/controls/tree/tree_view.cc View 1 chunk +3 lines, -1 line 0 comments Download
M views/focus/external_focus_tracker.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M views/focus/focus_manager.h View 9 chunks +67 lines, -18 lines 0 comments Download
M views/focus/focus_manager.cc View 9 chunks +211 lines, -13 lines 0 comments Download
D views/focus/focus_manager_gtk.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M views/focus/focus_manager_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
D views/focus/focus_manager_win.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M views/view.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M views/view_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M views/view_win.cc View 2 chunks +13 lines, -1 line 0 comments Download
M views/views.gyp View 2 chunks +3 lines, -5 lines 0 comments Download
M views/widget/accelerator_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M views/widget/root_view.cc View 3 chunks +17 lines, -4 lines 0 comments Download
M views/widget/widget.h View 2 chunks +2 lines, -7 lines 0 comments Download
M views/widget/widget_win.h View 5 chunks +6 lines, -11 lines 0 comments Download
M views/widget/widget_win.cc View 7 chunks +14 lines, -27 lines 0 comments Download
M views/window/window_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Nicolas Sylvain
11 years, 6 months ago (2009-06-22 15:03:04 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698