Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 140061: Send variable values in 'scopes' response (Closed)

Created:
11 years, 6 months ago by yurys
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Introduce an argument that allows to include some data neccessary for displaying collapsed scope variables values in graphical debugger. When request has 'inlineRefs' option simple type values will be written in the response directly. Variables of other types in addition to 'ref' property containing the value handle will contain some type information. Committed: http://code.google.com/p/v8/source/detail?r=2253

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M src/debug-delay.js View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M src/mirror-delay.js View 1 2 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
11 years, 6 months ago (2009-06-23 07:53:19 UTC) #1
Søren Thygesen Gjesse
LGTM
11 years, 6 months ago (2009-06-23 07:58:56 UTC) #2
yurys
11 years, 6 months ago (2009-06-23 09:26:05 UTC) #3
On 2009/06/23 07:58:56, Søren Gjesse wrote:
> LGTM

I've added a temporary check for request.arguments.compactFormat as well so that
the change doesn't break current ChromeDevTools.

Powered by Google App Engine
This is Rietveld 408576698