Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 140060: Enable code generation for array literals.... (Closed)

Created:
11 years, 6 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Enable code generation for array literals. Introduce macro assembler support for pushing heap-object handles and for comparing a register to a heap-object handle. Cleanup: Remove some code that was needlessly commented out. Added TODO's for code that was commented out (where we do not hit an UNIMPLEMENTED). Committed: http://code.google.com/p/v8/source/detail?r=2241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -38 lines) Patch
M src/x64/codegen-x64.cc View 15 chunks +139 lines, -38 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 6 months ago (2009-06-22 13:18:22 UTC) #1
William Hesse
11 years, 6 months ago (2009-06-22 15:05:24 UTC) #2
Merge changes in macroassembler-x64 with changes from r2238 (Move and Cmp
added).
LGTM.

Powered by Google App Engine
This is Rietveld 408576698