Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 140045: Generate all langpacks on Linux using gyp python list comprehensions.... (Closed)

Created:
11 years, 6 months ago by juhp
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Generate all langpacks on Linux using gyp python list comprehensions. Currently only 4 langpacks out of 50 odd are being built. This patch enables building all of them as on Windows, and factorizes the gyp lists using python comprehensions. BUG=14790 TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -143 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome.gyp View 4 chunks +19 lines, -143 lines 0 comments Download
M chrome/tools/build/linux/FILES View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
juhp
Hi my first chromium patch... this enables building all langpacks for linux with gyp like ...
11 years, 6 months ago (2009-06-20 12:20:17 UTC) #1
sgk
Hi Jens-- Thanks for submitting this. We're going to need to refactor this, though. Even ...
11 years, 6 months ago (2009-06-21 15:15:32 UTC) #2
juhp
> We're going to need to refactor this, though. Even > though we eval() the ...
11 years, 6 months ago (2009-06-22 04:48:23 UTC) #3
Evan Martin
11 years, 6 months ago (2009-06-22 23:10:00 UTC) #4
Michael Moss
11 years, 5 months ago (2009-07-15 17:49:00 UTC) #5
> Barring an outright loop in gyp, the best idea I can come up with is to use an
> external script to contain the list of language strings and to spit back lists
> that would be interpolated into gyp variables, and then use rules to
> pattern-match files specified in those lists in some clever way.  I haven't
> thought about it enough to have a sense for how to work out the details,
though.

FYI, I've implemented almost exactly what sgk describes here. I hope to send a
CL today.

Powered by Google App Engine
This is Rietveld 408576698