Issue 140044: Reorganize the way the task manager is constructed....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140044: Reorganize the way the task manager is constructed.... (Closed)

Created:
11 years, 6 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Reorganize the way the task manager is constructed. The BrowserWindow creates the task manager UI directly, which uses the TaskManager to populate itself. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18975

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -975 lines)			Patch
M	chrome/browser/browser.cc	View	1	1 chunk	+1 line, -6 lines	0 comments	Download
M	chrome/browser/browser_window.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_cocoa.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_cocoa.mm	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A +	chrome/browser/gtk/task_manager_gtk.cc	View	1	2 chunks	+6 lines, -39 lines	0 comments	Download
M	chrome/browser/task_manager.h	View	1	5 chunks	+12 lines, -37 lines	0 comments	Download
M	chrome/browser/task_manager.cc	View	1	2 chunks	+14 lines, -67 lines	0 comments	Download
M	chrome/browser/task_manager_browsertest.cc	View	1	1 chunk	+3 lines, -7 lines	0 comments	Download
D	chrome/browser/task_manager_linux.cc	View	1	1 chunk	+0 lines, -75 lines	0 comments	Download
M	chrome/browser/task_manager_unittest.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/browser/task_manager_win.cc	View	1	1 chunk	+0 lines, -633 lines	0 comments	Download
M	chrome/browser/views/browser_dialogs.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A +	chrome/browser/views/task_manager_view.cc	View	1	15 chunks	+109 lines, -108 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/test_browser_window.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages