Issue 140009: More CHECKs in my continuing effort to figure out what is going on. Neither ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140009: More CHECKs in my continuing effort to figure out what is going on. Neither ... (Closed)

Created:
11 years, 6 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

More CHECKs in my continuing effort to figure out what is going on. Neither Ben nor I can get this one. BUG=13500 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18947

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_popup_model.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM I'll reiterate my last comment though. I think you're going to need to more ...

11 years, 6 months ago (2009-06-22 15:50:30 UTC) #2

Peter Kasting

11 years, 6 months ago (2009-06-22 19:18:58 UTC) #3

On 2009/06/22 15:50:30, sky wrote:
> I'll reiterate my last comment though. I think you're going to need to more
> logging to catch this one when it happens, not after the fact.

I believe you but I don't know how to log such that when the crash happens with
the in-the-wild release build I will get the relevant logs.

Expand Messages | Collapse Messages