Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 140008: Add a switch to allow longer shutdown timeouts, since quitting under valgrind... (Closed)

Created:
11 years, 6 months ago by stuartmorgan
Modified:
9 years, 7 months ago
Reviewers:
TVL, dank
CC:
chromium-reviews_googlegroups.com, Nirnimesh
Visibility:
Public.

Description

Add a switch to allow longer shutdown timeouts, since quitting under valgrind is very slow on the Mac. BUG=none TEST=Most/all of the UI tests should pass on the Mac when run under valgrind. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M chrome/test/ui/ui_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 5 chunks +14 lines, -2 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
stuartmorgan
11 years, 6 months ago (2009-06-19 20:05:04 UTC) #1
TVL
11 years, 6 months ago (2009-06-21 23:25:22 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698