Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Issue 140003: Upgrade gtest to r267 and gmock to r173. (Closed)

Created:
11 years, 6 months ago by awong
Modified:
9 years, 7 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Upgrade gtest to r267 and gmock to r173. This is step1 into removing the boost + tr1 dependency in windows. It also includes a hack to avoid brining in tr1/functional on gcc, which will move us closer to enabling -fno-rtti. This CL has passed the try servers. I've also tried compiling gmock, gmock_main, base, base_unittests, and webcore modules in vs2008 express editions.

Patch Set 1 #

Patch Set 2 : Fix 80-char #

Total comments: 1

Patch Set 3 : Adding comments into gyp files #

Patch Set 4 : final fileset. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2458 lines, -1057 lines) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M testing/README.chromium View 1 2 chunks +13 lines, -32 lines 0 comments Download
M testing/chromium.patch View 1 chunk +0 lines, -20 lines 0 comments Download
M testing/gmock.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M testing/gmock/Makefile.am View 1 chunk +22 lines, -0 lines 0 comments Download
M testing/gmock/README View 6 chunks +32 lines, -49 lines 0 comments Download
M testing/gmock/configure.ac View 1 chunk +1 line, -1 line 0 comments Download
M testing/gmock/include/gmock/gmock.h View 1 chunk +4 lines, -4 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-matchers.h View 19 chunks +365 lines, -66 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-matchers.h.pump View 12 chunks +165 lines, -57 lines 0 comments Download
M testing/gmock/include/gmock/gmock-matchers.h View 5 chunks +172 lines, -26 lines 0 comments Download
M testing/gmock/include/gmock/gmock-printers.h View 6 chunks +70 lines, -31 lines 0 comments Download
M testing/gmock/include/gmock/gmock-spec-builders.h View 23 chunks +219 lines, -223 lines 0 comments Download
M testing/gmock/include/gmock/internal/gmock-internal-utils.h View 4 chunks +247 lines, -4 lines 0 comments Download
M testing/gmock/include/gmock/internal/gmock-port.h View 1 chunk +2 lines, -17 lines 0 comments Download
M testing/gmock/include/gmock/internal/gmock-port.h.orig View 1 chunk +0 lines, -326 lines 0 comments Download
M testing/gmock/msvc/gmock_config.vsprops View 1 chunk +1 line, -6 lines 0 comments Download
M testing/gmock/scripts/generator/README View 1 chunk +1 line, -1 line 0 comments Download
M testing/gmock/scripts/generator/cpp/ast.py View 3 chunks +9 lines, -5 lines 0 comments Download
M testing/gmock/scripts/generator/cpp/gmock_class.py View 5 chunks +13 lines, -6 lines 0 comments Download
A testing/gmock/scripts/generator/cpp/gmock_class_test.py View 1 chunk +137 lines, -0 lines 0 comments Download
M testing/gmock/scripts/gmock-config.in View 1 chunk +1 line, -1 line 0 comments Download
M testing/gmock/scripts/gmock_doctor.py View 21 chunks +124 lines, -32 lines 0 comments Download
M testing/gmock/src/gmock-internal-utils.cc View 3 chunks +27 lines, -17 lines 0 comments Download
M testing/gmock/src/gmock-printers.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/gmock/src/gmock-spec-builders.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/gmock/test/gmock-generated-actions_test.cc View 17 chunks +65 lines, -31 lines 0 comments Download
M testing/gmock/test/gmock-generated-matchers_test.cc View 12 chunks +220 lines, -8 lines 0 comments Download
M testing/gmock/test/gmock-internal-utils_test.cc View 4 chunks +261 lines, -0 lines 0 comments Download
M testing/gmock/test/gmock-matchers_test.cc View 11 chunks +112 lines, -11 lines 0 comments Download
M testing/gmock/test/gmock-printers_test.cc View 5 chunks +66 lines, -33 lines 0 comments Download
M testing/gmock/test/gmock-spec-builders_test.cc View 5 chunks +66 lines, -20 lines 0 comments Download
M testing/gmock/test/gmock_link_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M testing/gmock/test/gmock_output_test_.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M testing/gmock/test/gmock_output_test_golden.txt View 4 chunks +10 lines, -10 lines 0 comments Download
M testing/gtest.gyp View 1 2 2 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
awong
Ignore all the files in testing/gmock. That's just the new snapshot from gmock trunk. The ...
11 years, 6 months ago (2009-06-19 18:56:46 UTC) #1
John Grabowski
LGTM. Mock on! Given the wide scope of problems you've fixed in the past, it ...
11 years, 6 months ago (2009-06-19 19:35:14 UTC) #2
awong
11 years, 6 months ago (2009-06-20 00:12:18 UTC) #3
Thanks for the review.

I got vs2008 express edition installed again this afternoon and managed to some
simple tests.  It seems this doesn't break things, though I wasn't able to
reproduce narko's bug in the first place.

The scary change isn't this one though...it's the setting of _HAS_TR1=0 that
I'll try next week.

Anyways, still not submitting until next week since it's not 5pm on friday.

Powered by Google App Engine
This is Rietveld 408576698