Issue 140001: Fix default focus in Gears dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140001: Fix default focus in Gears dialogs (Closed)

Created:
11 years, 6 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Finnur

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

When initially focused, the DOMUI (used for Gears dialog) would not focus the tab correctly. BUG=14126 TEST=Use the "Create application shortcut..." menu to bring up the Gears dialog. Press tab, the focus should move around. Press ESC, the dialog should close. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18867

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/views/dom_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/views/dom_view.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages