Fix crasher in LocationBarViewMac::PageActionImageView::OnImageLoaded....

Fix crasher in LocationBarViewMac::PageActionImageView::OnImageLoaded.

Scott's insight in comment 18 on the bug report was correct; fixed by relinquishing control on call to UpdatePageActions, so that we don't try to look at the private variables of a dying this ptr.

BUG=35864
TEST= no crash.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42764

[Scott Hess - ex-Googler, 2010-03-26 00:29:57]

http://codereview.chromium.org/1397001/diff/3001/4002
File chrome/browser/cocoa/location_bar_view_mac.mm (right):

http://codereview.chromium.org/1397001/diff/3001/4002#newcode184
chrome/browser/cocoa/location_bar_view_mac.mm:184: [field_ display];
As I just suggested, maybe just [field_ setNeedsDisplay:YES] in
UpdatePageActions() will suffice.

The last line of the views version is |SchedulePaint()|, so this seems
reasonable.

[Miranda Callahan, 2010-03-26 00:39:17]

Works great, clean and simple.

http://codereview.chromium.org/1397001/diff/3001/4002
File chrome/browser/cocoa/location_bar_view_mac.mm (right):

http://codereview.chromium.org/1397001/diff/3001/4002#newcode184
chrome/browser/cocoa/location_bar_view_mac.mm:184: [field_ display];
On 2010/03/26 00:29:57, shess wrote:
> As I just suggested, maybe just [field_ setNeedsDisplay:YES] in
> UpdatePageActions() will suffice.
> 
> The last line of the views version is |SchedulePaint()|, so this seems
> reasonable.

Done.

[Scott Hess - ex-Googler, 2010-03-26 00:41:21]

LGTM!