Issue 1394003: AutoFill: Copy FormManager::LabelForElement and the corresponding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1394003: AutoFill: Copy FormManager::LabelForElement and the corresponding (Closed)

Created:
10 years, 9 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, darin-cc_chromium.org

Visibility:
Public.

Description

AutoFill: Copy FormManager::LabelForElement and the corresponding FormManager::InferLabelForElement to form_field.cc until the FormData/FormFieldValues consolidation is finished. BUG=33031 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42730

Patch Set 1 #

Patch Set 2 : Remove an old comment. #

Total comments: 2

Patch Set 3 : Add origin warning. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -4 lines)			Patch
	M	webkit/glue/form_field.cc	View	1 2	2 chunks	+73 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dhollowa

LGTM subject to requested warning in comment. http://codereview.chromium.org/1394003/diff/3001/4001 File webkit/glue/form_field.cc (right): http://codereview.chromium.org/1394003/diff/3001/4001#newcode22 webkit/glue/form_field.cc:22: // over ...

10 years, 9 months ago (2010-03-26 02:55:02 UTC) #2

James Hawkins

10 years, 9 months ago (2010-03-26 03:01:50 UTC) #3

http://codereview.chromium.org/1394003/diff/3001/4001
File webkit/glue/form_field.cc (right):

http://codereview.chromium.org/1394003/diff/3001/4001#newcode22
webkit/glue/form_field.cc:22: // over to using FormData.
On 2010/03/26 02:55:02, dhollowa wrote:
> Please add remark regarding origin of this code.  Maybe big bold warning that
if
> original changes then this should too.  At least until we can remove it.

Done.

Expand Messages | Collapse Messages