Update i18n pages to include predefined messages (e.g. @@bidi_dir)....

Update i18n pages to include predefined messages (e.g. @@bidi_dir).

TEST=none
BUG=35454
BUG=35056
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42887

[kathyw, 2010-03-26 06:51:31]

Did I get everything? I haven't tested the code, so please pay special attention
to that.

[Nebojša Ćirić, 2010-03-26 15:23:35]

On 2010/03/26 06:51:31, kathyw wrote:
> Did I get everything? I haven't tested the code, so please pay special
attention
> to that.

Thanks for doing this (extra points for doing it before the hackaton :)).

Some comments:

1. Use only supported locales - we are not that restrictive any more. One can
use any name under _locales folder, and we would still load the extension (but
would do LOG(WARNING) about it). Do you want me to file a separate bug about
this?

2. Reserved messages section
- @@extension_id I think can't be used in the manifest, only CSS and JS.
- "If the extension ID is abcdefghijklmnopqrstuvwxyzabcdef, then the bold line
becomes:" - did you want to refer to bold text here, or to the example above?

Cira

[kathyw, 2010-03-26 16:35:15]

> 1. Use only supported locales - we are not that restrictive any more. One can
> use any name under _locales folder, and we would still load the extension (but
> would do LOG(WARNING) about it). Do you want me to file a separate bug about
> this?

No, that's fine. I softened the language. Do you think that's enough?

> 2. Reserved messages section
> - @@extension_id I think can't be used in the manifest, only CSS and JS.

OK, I've made that change. Could you please check it?

> - "If the extension ID is abcdefghijklmnopqrstuvwxyzabcdef, then the bold line
> becomes:" - did you want to refer to bold text here, or to the example above?

Ah, that is confusing. I've rewritten it slightly.

Thanks for the quick review!

-k-

[Nebojša Ćirić, 2010-03-26 16:59:25]

"A special message named @@extension_id can be used in the CSS files of all
extensions, whether or not they're localized. This message also works in the
JavaScript files of localized extensions; it doesn't work in manifest files."

I just tested on latest Mac beta, and this message works both for CSS files and
JavaScript for unlocalized extensions.

It doesn't work in manifest for both localized and unlocalized messages.

As for the supported locales, you could add this part (in any form you see fit):
"If you use unsupported locale Chrome will ignore it"

On 2010/03/26 16:35:15, kathyw wrote:
> > 1. Use only supported locales - we are not that restrictive any more. One
can
> > use any name under _locales folder, and we would still load the extension
(but
> > would do LOG(WARNING) about it). Do you want me to file a separate bug about
> > this?
> 
> No, that's fine. I softened the language. Do you think that's enough?
> 
> > 2. Reserved messages section
> > - @@extension_id I think can't be used in the manifest, only CSS and JS.
> 
> OK, I've made that change. Could you please check it?
> 
> > - "If the extension ID is abcdefghijklmnopqrstuvwxyzabcdef, then the bold
line
> > becomes:" - did you want to refer to bold text here, or to the example
above?
> 
> Ah, that is confusing. I've rewritten it slightly.
> 
> Thanks for the quick review!
> 
> -k-

[Nebojša Ćirić, 2010-03-26 17:03:06]

To be precise about the beta version for Mac that works with @@ messages (307
doesn't)

5.0.342.7 (42476) beta

On 2010/03/26 16:59:25, Nebojša Ćirić wrote:
> "A special message named @@extension_id can be used in the CSS files of all
> extensions, whether or not they're localized. This message also works in the
> JavaScript files of localized extensions; it doesn't work in manifest files."
> 
> I just tested on latest Mac beta, and this message works both for CSS files
and
> JavaScript for unlocalized extensions.
> 
> It doesn't work in manifest for both localized and unlocalized messages.
> 
> As for the supported locales, you could add this part (in any form you see
fit):
> "If you use unsupported locale Chrome will ignore it"
> 
> On 2010/03/26 16:35:15, kathyw wrote:
> > > 1. Use only supported locales - we are not that restrictive any more. One
> can
> > > use any name under _locales folder, and we would still load the extension
> (but
> > > would do LOG(WARNING) about it). Do you want me to file a separate bug
about
> > > this?
> > 
> > No, that's fine. I softened the language. Do you think that's enough?
> > 
> > > 2. Reserved messages section
> > > - @@extension_id I think can't be used in the manifest, only CSS and JS.
> > 
> > OK, I've made that change. Could you please check it?
> > 
> > > - "If the extension ID is abcdefghijklmnopqrstuvwxyzabcdef, then the bold
> line
> > > becomes:" - did you want to refer to bold text here, or to the example
> above?
> > 
> > Ah, that is confusing. I've rewritten it slightly.
> > 
> > Thanks for the quick review!
> > 
> > -k-

[kathyw, 2010-03-26 18:45:28]

OK, I've fixed the text. How does it look now?

[Nebojša Ćirić, 2010-03-26 23:38:48]

LGTM

Haven't seen your reply until now, sorry.

Thanks, looks real good.

On 2010/03/26 18:45:28, kathyw wrote:
> OK, I've fixed the text. How does it look now?