Issue 1386002: autox: Fix race condition and add get_screen_size().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1386002: autox: Fix race condition and add get_screen_size(). (Closed)

Created:
10 years, 9 months ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Daniel Erat, Chris Masone

Visibility:
Public.

Description

autox: Fix race condition and add get_screen_size(). python-xlib reuses IDs for subsequent windows, which is very handy for finding buggy code. :-( When we create a new window, there may be an in-flight DestroyNotify event about a previous window sharing its ID. Sync before creating the new window to make sure that we don't misinterpret which window the event is about. BUG=none TEST=none

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -17 lines)			Patch
	M	src/platform/autox/autox.py	View		7 chunks	+22 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

Sorry, one more change. On the bright side, I've written a test that uses this ...

10 years, 9 months ago (2010-03-25 23:13:54 UTC) #1

lgtm!

Expand Messages | Collapse Messages