Move the Apps shortcut to the left of the bookmarks bar, and use new icon.

Move the Apps shortcut to the left of the bookmarks bar, and use new icon.


BUG=226887
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193272

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193307

[MAD, 2013-04-08 20:48:52]

Please take a peek before I ask for OWNERS reviews...

Thanks!

BYE
MAD

[beaudoin, 2013-04-09 18:25:58]

LGTM

[MAD, 2013-04-09 18:33:08]

Merci Phil...

oshima@ for theme asset OWNERS review and sky for browser/ui...

Thanks!

BYE
MAD

[oshima, 2013-04-09 19:17:54]

chrome/app/theme lgtm

[oshima, 2013-04-09 19:18:56]

On 2013/04/09 19:17:54, oshima wrote:
> chrome/app/theme lgtm

wait, file names are different for 100 and 200. Is this intentional?

[MAD, 2013-04-09 19:26:35]

Oups... no... Good catch... Update coming up...


On Tue, Apr 9, 2013 at 3:18 PM, <oshima@chromium.org> wrote:

> On 2013/04/09 19:17:54, oshima wrote:
>
>> chrome/app/theme lgtm
>>
>
> wait, file names are different for 100 and 200. Is this intentional?
>
>
https://codereview.chromium.**org/13800017/<https://codereview.chromium.org/1...
>

[MAD, 2013-04-09 19:28:45]

Updated name... Sorry about that... :-/

OK, now?

BYE
MAD

[oshima, 2013-04-09 20:05:56]

chrome/app/theme lgtm

[sky, 2013-04-09 21:36:18]

WTF?!? *SIGH* LGTM

[commit-bot: I haz the power, 2013-04-09 22:36:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mad@chromium.org/13800017/20001

[commit-bot: I haz the power, 2013-04-09 22:36:50]

Presubmit check for 13800017-20001 failed and returned exit status 1.

INFO:root:Found 4 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/app/theme/PRESUBMIT.py
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1293, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1117, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1034, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 19, in CheckChangeOnCommit
  File "<string>", line 43, in _CommonChecks
  File
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
line 85, in RunChecks
    base_dimensions = ImageSize(base_image)
  File
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
line 47, in ImageSize
    assert data[:8] == '\x89PNG\r\n\x1A\n' and data[12:16] == 'IHDR'
AssertionError

[oshima, 2013-04-09 23:01:46]

I think the image is either bad or has wrong size.
One in default_200_percent must have 2x size of one in default_100_percent.

Note that CQ can't commit binary files, so you need to manually dcommit png
files
even if you fix it. I should have mentioned it earlier, sorry.

On 2013/04/09 22:36:50, I haz the power (commit-bot) wrote:
> Presubmit check for 13800017-20001 failed and returned exit status 1.
> 
> INFO:root:Found 4 file(s).
> 
> Running presubmit commit checks ...
> Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
> Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
> Running /b/commit-queue/workdir/chromium/chrome/app/theme/PRESUBMIT.py
> Traceback (most recent call last):
>   File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
>     sys.exit(presubmit_support.Main(argv))
>   File "/b/depot_tools/presubmit_support.py", line 1293, in Main
>     rietveld_obj)
>   File "/b/depot_tools/presubmit_support.py", line 1117, in DoPresubmitChecks
>     results += executer.ExecPresubmitScript(presubmit_script, filename)
>   File "/b/depot_tools/presubmit_support.py", line 1034, in
ExecPresubmitScript
>     result = eval(function_name + '(*__args)', context)
>   File "<string>", line 1, in <module>
>   File "<string>", line 19, in CheckChangeOnCommit
>   File "<string>", line 43, in _CommonChecks
>   File
>
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
> line 85, in RunChecks
>     base_dimensions = ImageSize(base_image)
>   File
>
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
> line 47, in ImageSize
>     assert data[:8] == '\x89PNG\r\n\x1A\n' and data[12:16] == 'IHDR'
> AssertionError

[MAD, 2013-04-09 23:23:25]

I just checked and one is 16x16 and the other one is 32x32...

The error seem to indicate the format is not correct:

I saw:

  File
"/mnt/scratch0/b_used/build/slave/linux_chromeos/build/src/tools/grit/grit/gather/chrome_scaled_image.py",
line 67, in _ChunkifyPNG
    assert data.startswith(_PNG_MAGIC)



And I think I saw another one complaining about not being iHDR, but can't
find it anymore...




On Tue, Apr 9, 2013 at 7:01 PM, <oshima@chromium.org> wrote:

> I think the image is either bad or has wrong size.
> One in default_200_percent must have 2x size of one in default_100_percent.
>
> Note that CQ can't commit binary files, so you need to manually dcommit png
> files
> even if you fix it. I should have mentioned it earlier, sorry.
>
>
> On 2013/04/09 22:36:50, I haz the power (commit-bot) wrote:
>
>> Presubmit check for 13800017-20001 failed and returned exit status 1.
>>
>
>  INFO:root:Found 4 file(s).
>>
>
>  Running presubmit commit checks ...
>> Running /b/commit-queue/workdir/**chromium/PRESUBMIT.py
>> Running /b/commit-queue/workdir/**chromium/chrome/PRESUBMIT.py
>> Running /b/commit-queue/workdir/**chromium/chrome/app/theme/**
>> PRESUBMIT.py
>> Traceback (most recent call last):
>>    File "/b/commit-queue/verification/**presubmit_shim.py", line 33, in
>> <module>
>>      sys.exit(presubmit_support.**Main(argv))
>>    File "/b/depot_tools/presubmit_**support.py", line 1293, in Main
>>      rietveld_obj)
>>    File "/b/depot_tools/presubmit_**support.py", line 1117, in
>> DoPresubmitChecks
>>      results += executer.ExecPresubmitScript(**presubmit_script,
>> filename)
>>    File "/b/depot_tools/presubmit_**support.py", line 1034, in
>>
> ExecPresubmitScript
>
>>      result = eval(function_name + '(*__args)', context)
>>    File "<string>", line 1, in <module>
>>    File "<string>", line 19, in CheckChangeOnCommit
>>    File "<string>", line 43, in _CommonChecks
>>    File
>>
>
> "/b/commit-queue/workdir/**chromium/chrome/app/theme/../.**
> ./../ui/resources/resource_**check/resource_scale_factors.**py",
>
>> line 85, in RunChecks
>>      base_dimensions = ImageSize(base_image)
>>    File
>>
>
> "/b/commit-queue/workdir/**chromium/chrome/app/theme/../.**
> ./../ui/resources/resource_**check/resource_scale_factors.**py",
>
>> line 47, in ImageSize
>>      assert data[:8] == '\x89PNG\r\n\x1A\n' and data[12:16] == 'IHDR'
>> AssertionError
>>
>
>
>
>
https://chromiumcodereview.**appspot.com/13800017/<https://chromiumcodereview...
>

[commit-bot: I haz the power, 2013-04-10 01:06:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mad@chromium.org/13800017/25001

[commit-bot: I haz the power, 2013-04-10 03:38:13]

Change committed as 193307