Give an error when setting break points in functions either defined through t...

src/debug-delay.js

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 456 matching lines @@
   if (break_point) {
     return break_point;
   } else {
     return this.findScriptBreakPoint(break_point_number, remove);
   }
 };
 
 
 Debug.setBreakPoint = function(func, opt_line, opt_column, opt_condition) {
   if (!IS_FUNCTION(func)) throw new Error('Parameters have wrong types.');
+  // Break points in API functions are not supported.
+  if (%FunctionIsAPIFunction(func)) {
+    throw new Error('Cannot set break point in native code.');

[Christian Plesner Hansen, 2008/12/15 09:01:46]

Given that all our code is native this error message might be confusing.

[Søren Thygesen Gjesse, 2008/12/15 09:29:50]

I decided on the error message based on the "toString" for a n API function
returns [native code], e.g.

function print() { [native code] }

[Christian Plesner Hansen, 2008/12/15 09:35:29]

Good point, let's stay consistent.  (I remember fighting against that toString
by the way.)

+  }
   var source_position = this.findFunctionSourcePosition(func, opt_line, opt_column) -
                         this.sourcePosition(func);
   // Find the script for the function.
   var script = %FunctionGetScript(func);
+  // Break in builtin JavaScript code is not supported.
+  if (script.type == Debug.ScriptType.Native) {
+    throw new Error('Cannot set break point in native code.');
+  }
   // If the script for the function has a name convert this to a script break
   // point.
   if (script && script.name) {
     // Adjust the source position to be script relative.
     source_position += %FunctionGetScriptSourcePosition(func);
     // Find line and column for the position in the script and set a script
     // break point from that.
     var location = script.locationFromPosition(source_position);
     return this.setScriptBreakPoint(script.name,
                                     location.line, location.column,
@@ skipping 1163 matching lines @@
       json += NumberToJSON_(elem);
     } else if (IS_STRING(elem)) {
       json += StringToJSON_(elem);
     } else {
       json += elem;
     }
   }
   json += ']';
   return json;
 }