Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Issue 13785: Give an error when setting break points in functions either defined through t... (Closed)

Created:
12 years ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Give an error when setting break points in functions either defined through the API or in functions which are part of the V8 builtins. BUG=178 Committed: http://code.google.com/p/v8/source/detail?r=977

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/debug-delay.js View 1 chunk +8 lines, -0 lines 3 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Thygesen Gjesse
12 years ago (2008-12-12 11:14:31 UTC) #1
Christian Plesner Hansen
Lgtm http://codereview.chromium.org/13785/diff/1/2 File src/debug-delay.js (right): http://codereview.chromium.org/13785/diff/1/2#newcode479 Line 479: throw new Error('Cannot set break point in ...
12 years ago (2008-12-15 09:01:46 UTC) #2
Søren Thygesen Gjesse
http://codereview.chromium.org/13785/diff/1/2 File src/debug-delay.js (right): http://codereview.chromium.org/13785/diff/1/2#newcode479 Line 479: throw new Error('Cannot set break point in native ...
12 years ago (2008-12-15 09:29:50 UTC) #3
Christian Plesner Hansen
12 years ago (2008-12-15 09:35:29 UTC) #4
http://codereview.chromium.org/13785/diff/1/2
File src/debug-delay.js (right):

http://codereview.chromium.org/13785/diff/1/2#newcode479
Line 479: throw new Error('Cannot set break point in native code.');
Good point, let's stay consistent.  (I remember fighting against that toString
by the way.)

Powered by Google App Engine
This is Rietveld 408576698