Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 13780: Exposing the Close() method publicly in the ScopedHandle class.... (Closed)

Created:
12 years ago by tommi (sloooow) - chröme
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Exposing the Close() method publicly in the ScopedHandle class. This is to be more consistent with the interface defined in scoped_handle.h (ScopedStdioHandle) and also to avoid making the user make an explicit, Windows specific call to close the handle The recommendation is currently to do ::CloseHandle(h.Take()); which is less portable. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M base/scoped_handle_win.h View 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tommi (sloooow) - chröme
12 years ago (2008-12-12 05:43:27 UTC) #1
Nicolas Sylvain
12 years ago (2008-12-12 06:02:35 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698