Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: tools/valgrind/chrome_tests.py

Issue 1377003: Add win32 gtest filter files shared between Wine and TSan/Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/data/valgrind/base_unittests.gtest_wine.txt ('k') | tools/valgrind/common.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/chrome_tests.py
===================================================================
--- tools/valgrind/chrome_tests.py (revision 43070)
+++ tools/valgrind/chrome_tests.py (working copy)
@@ -135,12 +135,12 @@
if os.path.exists(suppression_file):
cmd.append("--suppressions=%s" % suppression_file)
# Platform specific suppression
- suppression_platform = common.PlatformName()
- suppression_file_platform = \
- os.path.join(directory,
- '%s/suppressions_%s.txt' % (tool_name, suppression_platform))
- if os.path.exists(suppression_file_platform):
- cmd.append("--suppressions=%s" % suppression_file_platform)
+ for suppression_platform in common.PlatformNames():
+ suppression_file_platform = \
+ os.path.join(directory,
+ '%s/suppressions_%s.txt' % (tool_name, suppression_platform))
+ if os.path.exists(suppression_file_platform):
+ cmd.append("--suppressions=%s" % suppression_file_platform)
cmd.append("--tool=%s" % self._options.valgrind_tool)
if self._options.valgrind_tool_flags:
@@ -171,11 +171,12 @@
'''
filters = []
for directory in self._data_dirs:
- platform_suffix = common.PlatformName()
gtest_filter_files = [
os.path.join(directory, name + ".gtest.txt"),
os.path.join(directory, name + ".gtest-%s.txt" % \
- self._options.valgrind_tool),
+ self._options.valgrind_tool)]
+ for platform_suffix in common.PlatformNames():
+ gtest_filter_files += [
os.path.join(directory, name + ".gtest_%s.txt" % platform_suffix),
os.path.join(directory, name + ".gtest-%s_%s.txt" % \
(self._options.valgrind_tool, platform_suffix))]
« no previous file with comments | « base/data/valgrind/base_unittests.gtest_wine.txt ('k') | tools/valgrind/common.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698