Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1377001: [GTTF] Various ui tests cleanups: (Closed)

Created:
10 years, 9 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
huanr, sky
CC:
chromium-reviews
Visibility:
Public.

Description

[GTTF] Various ui tests cleanups: - unify timeout handling - remove unneccessary assertions that clutter the code They were mostly there because earlier the automation framework was less reliable. Now the same checks (or equivalent) are always done in the framework itself. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42767

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -110 lines) Patch
M chrome/browser/browser_encoding_uitest.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/browser_uitest.cc View 8 chunks +4 lines, -55 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui_uitest.cc View 5 chunks +2 lines, -19 lines 0 comments Download
M chrome/browser/errorpage_uitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/redirect_uitest.cc View 1 chunk +0 lines, -3 lines 1 comment Download
M chrome/browser/iframe_uitest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/images_uitest.cc View 1 chunk +7 lines, -15 lines 1 comment Download
M chrome/test/ui/ui_test.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
10 years, 9 months ago (2010-03-25 21:21:25 UTC) #1
sky
LGTM http://codereview.chromium.org/1377001/diff/1/7 File chrome/browser/history/redirect_uitest.cc (right): http://codereview.chromium.org/1377001/diff/1/7#newcode23 chrome/browser/history/redirect_uitest.cc:23: class RedirectTest : public UITest { Go with: ...
10 years, 9 months ago (2010-03-25 22:08:06 UTC) #2
huanr
10 years, 9 months ago (2010-03-26 18:55:03 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698