Issue 13756: Fix issue 3620...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13756: Fix issue 3620... (Closed)

Created:
12 years ago by jhaas

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix issue 3620 Logic in Path::arc() determines what angle should be passed to Skia for the newly-drawn arc. This was buggy in the case of drawing clockwise arcs where the start angle is greater than the end angle (on an absolute scale). Specifically, some schmuck named jhaas used a minus sign where a plus sign would have worked much better. Honestly I'm flabbergasted this hasn't shown up earlier than this. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6828

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	webkit/port/platform/graphics/PathSkia.cpp	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, I hope this is the last bug with this code!

Expand Messages | Collapse Messages