Changed the debugger break handling to support situations where there are no ...

Changed the debugger break handling to support situations where there are no stack frames. This can happen when an exception is thrown when compiling code.

This is related to Chromium issue 5349 (http://code.google.com/p/chromium/issues/detail?id=5349).

Committed: http://code.google.com/p/v8/source/detail?r=959

[Mads Ager (chromium), 2008-12-11 07:56:54]

LGTM

http://codereview.chromium.org/13720/diff/1/3
File src/debug.h (right):

http://codereview.chromium.org/13720/diff/1/3#newcode527
Line 527: const bool has_js_frames_;  // Where there any JavaScript frames?
Where -> Were

http://codereview.chromium.org/13720/diff/1/4
File src/runtime.cc (right):

http://codereview.chromium.org/13720/diff/1/4#newcode4827
Line 4827: // If there is no JavaScript stack frame is undefined.
is -> return?

http://codereview.chromium.org/13720/diff/1/2
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/13720/diff/1/2#newcode480
Line 480: // height is there is a function compiled for that.
is there -> if there

http://codereview.chromium.org/13720/diff/1/2#newcode2357
Line 2357: // Test break on exception from compiler errors. When compiling using
using
using using -> using

[Søren Thygesen Gjesse, 2008-12-11 08:04:49]

http://codereview.chromium.org/13720/diff/1/3
File src/debug.h (right):

http://codereview.chromium.org/13720/diff/1/3#newcode527
Line 527: const bool has_js_frames_;  // Where there any JavaScript frames?
On 2008/12/11 07:56:54, Mads Ager wrote:
> Where -> Were

Done.

http://codereview.chromium.org/13720/diff/1/4
File src/runtime.cc (right):

http://codereview.chromium.org/13720/diff/1/4#newcode4827
Line 4827: // If there is no JavaScript stack frame is undefined.
On 2008/12/11 07:56:54, Mads Ager wrote:
> is -> return?

Done.

http://codereview.chromium.org/13720/diff/1/2
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/13720/diff/1/2#newcode480
Line 480: // height is there is a function compiled for that.
On 2008/12/11 07:56:54, Mads Ager wrote:
> is there -> if there

Done.

http://codereview.chromium.org/13720/diff/1/2#newcode2357
Line 2357: // Test break on exception from compiler errors. When compiling using
using
On 2008/12/11 07:56:54, Mads Ager wrote:
> using using -> using

Done.