Issue 1371005: Add tests for ibus-gconf.

Issue 1371005: Add tests for ibus-gconf. (Closed)

Created:
10 years, 9 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-os-reviews_chromium.org, kmixter1, petkov, seano, ericli, sosa, mazda

Visibility:
Public.

Patch Set 3 : changed to cc+py test #

Total comments: 21

Patch Set 4 : addressed all comments #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -4 lines)			Patch
	M	client/deps/ibusclient/src/ibusclient.cc	View	1 2 3	3 chunks	+135 lines, -4 lines	0 comments	Download
	M	client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py	View	3	2 chunks	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

Moved TestConfig method in ibusclient.cc to Python side following your suggestion. Can you take another ...

10 years, 9 months ago (2010-03-26 11:30:01 UTC) #2

satorux1

On 2010/03/26 11:30:01, Yusuke Sato wrote: > Moved TestConfig method in ibusclient.cc to Python side ...

10 years, 9 months ago (2010-03-26 15:14:48 UTC) #3

satorux1

http://codereview.chromium.org/1371005/diff/5001/6001 File client/deps/ibusclient/src/ibusclient.cc (right): http://codereview.chromium.org/1371005/diff/5001/6001#newcode21 client/deps/ibusclient/src/ibusclient.cc:21: void UnsetConfigAndPrintResult(IBusConfig* ibus_config) { Please add a one line ...

10 years, 9 months ago (2010-03-26 15:15:05 UTC) #4

Yusuke Sato

10 years, 9 months ago (2010-03-26 23:34:13 UTC) #5

thanks for the quick review!

http://codereview.chromium.org/1371005/diff/5001/6001
File client/deps/ibusclient/src/ibusclient.cc (right):

http://codereview.chromium.org/1371005/diff/5001/6001#newcode21
client/deps/ibusclient/src/ibusclient.cc:21: void
UnsetConfigAndPrintResult(IBusConfig* ibus_config) {
On 2010/03/26 15:15:05, satorux1 wrote:
> Please add a one line coment.

Done.

http://codereview.chromium.org/1371005/diff/5001/6001#newcode29
client/deps/ibusclient/src/ibusclient.cc:29: void SetConfigAndPrintResult(
On 2010/03/26 15:15:05, satorux1 wrote:
> ditto.

Done.

http://codereview.chromium.org/1371005/diff/5001/6001#newcode46
client/deps/ibusclient/src/ibusclient.cc:46: printf("FAIL (unknown type)\n");
On 2010/03/26 15:15:05, satorux1 wrote:
> Would be nice to print the unknown type with %s

Done.

http://codereview.chromium.org/1371005/diff/5001/6001#newcode58
client/deps/ibusclient/src/ibusclient.cc:58: void GetConfigAndPrintResult(
On 2010/03/26 15:15:05, satorux1 wrote:
> one line comment

Done.

http://codereview.chromium.org/1371005/diff/5001/6001#newcode72
client/deps/ibusclient/src/ibusclient.cc:72: }
On 2010/03/26 15:15:05, satorux1 wrote:
> would be nice to print the value on success?

let me skip this since the value is fixed (TRUE in this case) and the value is
checked at L.69.

http://codereview.chromium.org/1371005/diff/5001/6001#newcode81
client/deps/ibusclient/src/ibusclient.cc:81: (g_value_get_double(&gvalue) <
kDummyValueDouble - 0.001) ||
On 2010/03/26 15:15:05, satorux1 wrote:
> Would be nice to add a comment saying we allow errors here.

Done.

http://codereview.chromium.org/1371005/diff/5001/6001#newcode120
client/deps/ibusclient/src/ibusclient.cc:120: "                     Set a dummy
value to ibus-gconf\n");
On 2010/03/26 15:15:05, satorux1 wrote:
> The config service doesn't have to be ibus-gconfig, and we plan to replace it
> with something different, right?
> Maybe we could just call it "the ibus config service" here.

Done.

http://codereview.chromium.org/1371005/diff/5001/6001#newcode122
client/deps/ibusclient/src/ibusclient.cc:122: "                     Get a dummy
value from ibus-gconf\n");
On 2010/03/26 15:15:05, satorux1 wrote:
> ditto. other places too.

Done.

http://codereview.chromium.org/1371005/diff/5001/6002
File client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py (right):

http://codereview.chromium.org/1371005/diff/5001/6002#newcode55
client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:55: raise
error.TestFail('Failed to set %s value to ibus-gconf'
On 2010/03/26 15:15:05, satorux1 wrote:
> ibus-gconfig -> the ibus config service
> ?

Done.

http://codereview.chromium.org/1371005/diff/5001/6002#newcode70
client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:70: 
On 2010/03/26 15:15:05, satorux1 wrote:
> you could call get_config again to make sure it's really unset?

Hm, I think L.65 is doing this.

Expand Messages | Collapse Messages