Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1369003: Change a TypeInfo function from inline to non-inline, reducing stack usage du... (Closed)

Created:
10 years, 9 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Change a TypeInfo function from inline to non-inline, reducing stack usage during code compilation. Committed: http://code.google.com/p/v8/source/detail?r=4297

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -62 lines) Patch
M src/SConscript View 1 chunk +1 line, -0 lines 0 comments Download
M src/frame-element.h View 1 chunk +1 line, -1 line 0 comments Download
M src/register-allocator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.h View 1 chunk +1 line, -1 line 0 comments Download
A src/type-info.cc View 1 chunk +51 lines, -0 lines 0 comments Download
D src/type-info-inl.h View 1 chunk +0 lines, -55 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download
M tools/visual_studio/v8_base.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M tools/visual_studio/v8_base_arm.vcproj View 1 chunk +1 line, -1 line 0 comments Download
M tools/visual_studio/v8_base_x64.vcproj View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
William Hesse
10 years, 9 months ago (2010-03-26 11:22:12 UTC) #1
fschneider
10 years, 9 months ago (2010-03-26 11:24:57 UTC) #2
LGTM if it compiles.

Please also update the vcproj-files.

Powered by Google App Engine
This is Rietveld 408576698