Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 1367002: Revert 42665 - broke build as I missed a unit test when building locally.... (Closed)

Created:
10 years, 9 months ago by joth
Modified:
9 years, 7 months ago
Reviewers:
joth
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Revert 42665 - broke build as I missed a unit test when building locally. Adds geolocaiton support to the location bar content image model and content bubble model. Most of these edits were lifted out of http://codereview.chromium.org/650180 TODO: add geolocation support to the views in the three UI platforms for the bubble model. (NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs) BUG=11246 TEST=open a site that uses geolocaiton, select allow/deny & click the icon. Review URL: http://codereview.chromium.org/1344002 TBR=joth@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -158 lines) Patch
M chrome/app/theme/theme_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
MM chrome/browser/content_setting_bubble_model.h View 4 chunks +0 lines, -15 lines 0 comments Download
MM chrome/browser/content_setting_bubble_model.cc View 7 chunks +1 line, -68 lines 0 comments Download
M chrome/browser/content_setting_image_model.cc View 2 chunks +26 lines, -73 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
joth
10 years, 9 months ago (2010-03-25 20:58:34 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698