Issue 13657: Moved the code generation for debug break stubs from builtins* to debug*. Fro...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13657: Moved the code generation for debug break stubs from builtins* to debug*. Fro... (Closed)

Created:
12 years ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Moved the code generation for debug break stubs from builtins* to debug*. From builtins* all code generation delegate to debug*. Added files debug-ia32.cc and debug-arm.cc for platfoem specific code generation of debugger stubs. Removed a dead file reference (frames-ia32-inl.h) from the Visual Studio project. Updated the ARM Visual Studio project to build again by adding all the RegExp files. Committed: http://code.google.com/p/v8/source/detail?r=947

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+478 lines, -292 lines)			Patch
M	src/SConscript	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/builtins.h	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	src/builtins.cc	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	src/builtins-arm.cc	View	1 chunk	+0 lines, -127 lines	0 comments	Download
M	src/builtins-ia32.cc	View	2 chunks	+0 lines, -143 lines	0 comments	Download
M	src/debug.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	src/debug-arm.cc	View	1 chunk	+170 lines, -0 lines	0 comments	Download
A	src/debug-ia32.cc	View	1 chunk	+185 lines, -0 lines	0 comments	Download
M	src/stub-cache.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/visual_studio/v8_base.vcproj	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/visual_studio/v8_base_arm.vcproj	View	6 chunks	+56 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages