Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: src/ic.cc

Issue 13655: Make Logger::SuspectReadEvent extract the class name from the object. (Closed)
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/log.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 496 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 507
508 // Named lookup in the object. 508 // Named lookup in the object.
509 LookupResult lookup; 509 LookupResult lookup;
510 object->Lookup(*name, &lookup); 510 object->Lookup(*name, &lookup);
511 511
512 // If lookup is invalid, check if we need to throw an exception. 512 // If lookup is invalid, check if we need to throw an exception.
513 if (!lookup.IsValid()) { 513 if (!lookup.IsValid()) {
514 if (FLAG_strict || is_contextual()) { 514 if (FLAG_strict || is_contextual()) {
515 return ReferenceError("not_defined", name); 515 return ReferenceError("not_defined", name);
516 } 516 }
517 String* class_name = object->IsJSObject() 517 LOG(SuspectReadEvent(*name, *object));
518 ? Handle<JSObject>::cast(object)->class_name()
519 : Heap::empty_string();
520 LOG(SuspectReadEvent(*name, class_name));
521 USE(class_name);
522 } 518 }
523 519
524 // Update inline cache and stub cache. 520 // Update inline cache and stub cache.
525 if (FLAG_use_ic && lookup.IsLoaded()) { 521 if (FLAG_use_ic && lookup.IsLoaded()) {
526 UpdateCaches(&lookup, state, object, name); 522 UpdateCaches(&lookup, state, object, name);
527 } 523 }
528 524
529 PropertyAttributes attr; 525 PropertyAttributes attr;
530 if (lookup.IsValid() && lookup.type() == INTERCEPTOR) { 526 if (lookup.IsValid() && lookup.type() == INTERCEPTOR) {
531 // Get the property. 527 // Get the property.
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
1199 #undef ADDR 1195 #undef ADDR
1200 }; 1196 };
1201 1197
1202 1198
1203 Address IC::AddressFromUtilityId(IC::UtilityId id) { 1199 Address IC::AddressFromUtilityId(IC::UtilityId id) {
1204 return IC_utilities[id]; 1200 return IC_utilities[id];
1205 } 1201 }
1206 1202
1207 1203
1208 } } // namespace v8::internal 1204 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698