Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/dom_ui/bookmarks_ui_uitest.cc

Issue 1365003: Add some more EXPECT_TRUE to track down the valgrind issue.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/bookmarks_ui_uitest.cc
===================================================================
--- chrome/browser/dom_ui/bookmarks_ui_uitest.cc (revision 42663)
+++ chrome/browser/dom_ui/bookmarks_ui_uitest.cc (working copy)
@@ -33,9 +33,13 @@
EXPECT_TRUE(tab.get());
if (!tab.get())
return NULL;
- if (!tab->NavigateToURL(GURL(chrome::kChromeUIBookmarksURL)))
+ bool success = tab->NavigateToURL(GURL(chrome::kChromeUIBookmarksURL));
+ EXPECT_TRUE(success);
+ if (!success)
return NULL;
- if (!WaitForBookmarksUI(tab))
+ success = WaitForBookmarksUI(tab);
+ EXPECT_TRUE(success);
+ if (!success)
return NULL;
return tab;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698