Issue 1365001: eliminate the non-vbo code path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1365001: eliminate the non-vbo code path (Closed)

Created:
10 years, 9 months ago by papakipos

Modified:
9 years, 7 months ago

Reviewers:
Alexey Marinichev

CC:
chromium-os-reviews_chromium.org, kmixter1, petkov, seano, ericli, sosa

Visibility:
Public.

Description

eliminate the non-vbo code path failing vbo allocation is now a fatal CHECK failure. tested by building and running autotest on eee-pc.

Patch Set 1 #

Patch Set 2 : Fixed a CHECK call that failed lint #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -21 lines)			Patch
	M	client/deps/glbench/src/main.cc	View	1	10 chunks	+10 lines, -21 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

papakipos

Cleanup of old vbo-failure handling code, as requested.

10 years, 9 months ago (2010-03-25 20:27:17 UTC) #1

Alexey Marinichev

10 years, 9 months ago (2010-03-25 21:01:56 UTC) #2

LGTM

http://codereview.chromium.org/1365001/diff/3001/4001
File client/deps/glbench/src/main.cc (right):

http://codereview.chromium.org/1365001/diff/3001/4001#newcode118
client/deps/glbench/src/main.cc:118: CHECK(!glGetError());
I personally prefer explicit comparisons for ints (I use bang on bools), don't
know what our official conventions say.  Up to you.

Expand Messages | Collapse Messages