Issue 1363003: Add mock https server cert/key to testing builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1363003: Add mock https server cert/key to testing builds (Closed)

Created:
10 years, 9 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Add mock https server cert/key to testing builds

Patch Set 2 : making sure I fixed a botched merge #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	A	src/scripts/mod_for_test_scripts/710enableAuthTesting	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM http://codereview.chromium.org/1363003/diff/1/2 File src/scripts/mod_for_test_scripts/710enableAuthTesting (right): http://codereview.chromium.org/1363003/diff/1/2#newcode13 src/scripts/mod_for_test_scripts/710enableAuthTesting:13: cat "${CERT_DIR}/${CERT_NAME}.key" > "${ROOT_FS_DIR}/etc/${CERT_NAME}.key" cat vs cp ?

10 years, 9 months ago (2010-03-26 04:09:19 UTC) #2

Chris Masone

10 years, 9 months ago (2010-03-26 15:54:33 UTC) #3

On 2010/03/26 04:09:19, petkov wrote:
> LGTM
> 
> http://codereview.chromium.org/1363003/diff/1/2
> File src/scripts/mod_for_test_scripts/710enableAuthTesting (right):
> 
> http://codereview.chromium.org/1363003/diff/1/2#newcode13
> src/scripts/mod_for_test_scripts/710enableAuthTesting:13: cat
> "${CERT_DIR}/${CERT_NAME}.key" > "${ROOT_FS_DIR}/etc/${CERT_NAME}.key"
> cat vs cp ?

Yeah, I didn't want changes in the ownership/perms to propagate into the image.

Expand Messages | Collapse Messages

Issue 1363003: Add mock https server cert/key to testing builds (Closed)

Description

Patch Set 1 #

Patch Set 2 : making sure I fixed a botched merge #

Messages