Issue 1361004: Clarify a comment about the geolocation content settings map...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1361004: Clarify a comment about the geolocation content settings map... (Closed)

Created:
10 years, 9 months ago by joth

Modified:
9 years, 7 months ago

Reviewers:
bulach

CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Clarify a comment about the geolocation content settings map BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42755

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/tab_contents/tab_contents.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bulach

10 years, 9 months ago (2010-03-26 14:01:49 UTC) #2

LGTM

the first part about full URL is fine, the second about snapshot versus
persisted seems an overkill, specially since it gives an impression it's
different from the IsContentBlocked() just above...

On 2010/03/26 13:50:24, joth wrote:
>

Expand Messages | Collapse Messages