Issue 136001: Changed allocation to allow large objects to be allocated in new space....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136001: Changed allocation to allow large objects to be allocated in new space.... (Closed)

Created:
11 years, 6 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Changed allocation to allow large objects to be allocated in new space. This avoids back-to-back mark-sweep collections. Committed: http://code.google.com/p/v8/source/detail?r=2219

Patch Set 1 #

Total comments: 4

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+117 lines, -73 lines)			Patch
M	src/heap.h	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/heap.cc	View	14 chunks	+83 lines, -48 lines	1 comment	Download
M	src/heap-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/builtins-ia32.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mark-compact.cc	View	2 chunks	+10 lines, -6 lines	3 comments	Download
M	src/serialize.cc	View	1 chunk	+11 lines, -7 lines	0 comments	Download
M	src/spaces.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-mark-compact.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 6 months ago (2009-06-18 14:01:20 UTC) #2

LGTM

http://codereview.chromium.org/136001/diff/1/4
File src/heap.cc (right):

http://codereview.chromium.org/136001/diff/1/4#newcode724
Line 724: 
Accidental edit?

http://codereview.chromium.org/136001/diff/1/9
File src/mark-compact.cc (right):

http://codereview.chromium.org/136001/diff/1/9#newcode950
Line 950: // strings are promoted to the code space, all others to the old
space.
Not your code, but this comment seems wrong.  Heap numbers and sequential
strings are promoted to old data space, not code space.

http://codereview.chromium.org/136001/diff/1/9#newcode952
Line 952: Object* forwarded ;
Remove space before ';'.

http://codereview.chromium.org/136001/diff/1/9#newcode1681
Line 1681: reinterpret_cast<OldSpace*>(space)->MCAdjustRelocationEnd(new_addr,
obj_size);
space is already has type OldSpace*, so there should be no need for the cast?

Expand Messages | Collapse Messages