Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1359002: Proper constraints for inline implementation in assembly. (Closed)

Created:
10 years, 9 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Proper constraints for inline implementation in assembly. Committed: http://code.google.com/p/v8/source/detail?r=4291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/utils.h View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
antonm
Guys, may you have a look? And yes, inline assembly is evil. Fortunately it should ...
10 years, 9 months ago (2010-03-25 19:26:48 UTC) #1
Mads Ager (chromium)
LGTM Inline assembly is indeed nasty.
10 years, 9 months ago (2010-03-26 07:45:02 UTC) #2
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-26 07:49:44 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698