Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1353002: Reverting this CL to see if this fixes chrome frame unit test failures.... (Closed)

Created:
10 years, 9 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
slightlyoff
CC:
chromium-reviews, amit, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Reverting this CL to see if this fixes chrome frame unit test failures. Revert 42684 - Implements IDeleteBrowsing history and moves the GCF profile into the IE TIF directory for nonpriv mode users on IE < 8. Implementation notes: Earlier work enabled InPrivate browsing detection and mapped it to creation of an incognito profile instance.Privacy features and how they operate with this change: "Delete Browsing History": IE 6 & 7: all history (including databases) is deleted if cache is cleared *WITHOUT* an active Chrome process holding references to the profile resources. If GCF is rendering a page when the cache is cleared, history *WILL NOT* be deleted on the GCF side, however GCF will continue to operate and IE will remove all other history artifacts as usual. IE 8: GCF cache is cleared in alignment with the options specified by the user. Clearing Temporary Internet Files may destroy the profile entirely, and so we need to consider not moving the GCF profile on IE 8. "InPrivate Filtering": IE 8 (only): more testing required. "InPrivate Browsing": IE 8 (only): pages rendered in GCF *after* entering InPrivate mode are not persisted to disk (use an incognito wrapper on the specified profile). Currently displayed pages are not effected by the switch, although refreshing them will invoke the new behavior. Generally speaking, BHO's are disabled by IE 8 while in InPrivate mode, so entering this state is wonky to begin with but we handle it as well as can be expected. BUG=22846 TEST=On IE 8, clear the cache entirely, note GCF entries in DbgView (better tests coming) Review URL: http://codereview.chromium.org/858003 TBR=slightlyoff@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42691

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -353 lines) Patch
M chrome/browser/automation/automation_provider.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/automation/chrome_frame_automation_provider.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/test/automation/automation_messages_internal.h View 2 chunks +1 line, -7 lines 0 comments Download
M chrome_frame/bho.h View 4 chunks +0 lines, -14 lines 0 comments Download
M chrome_frame/bho.rgs View 1 chunk +23 lines, -26 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome_frame/chrome_frame_activex_base.h View 4 chunks +17 lines, -22 lines 0 comments Download
M chrome_frame/chrome_frame_automation.h View 4 chunks +2 lines, -6 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 10 chunks +24 lines, -12 lines 0 comments Download
M chrome_frame/chrome_frame_plugin.h View 5 chunks +1 line, -14 lines 0 comments Download
D chrome_frame/delete_chrome_history.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome_frame/delete_chrome_history.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M chrome_frame/test/automation_client_mock.h View 4 chunks +7 lines, -9 lines 0 comments Download
M chrome_frame/test/automation_client_mock.cc View 12 chunks +12 lines, -21 lines 0 comments Download
M chrome_frame/test/chrome_frame_automation_mock.h View 2 chunks +1 line, -7 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.h View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 3 chunks +1 line, -10 lines 0 comments Download
M chrome_frame/utils.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome_frame/utils.cc View 2 chunks +0 lines, -29 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ananta
10 years, 9 months ago (2010-03-25 23:16:26 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698