Issue 1343002: Re-submit of GCF privacy patch in:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1343002: Re-submit of GCF privacy patch in:... (Closed)

Created:
10 years, 9 months ago by slightlyoff

Modified:
9 years, 7 months ago

Reviewers:
ananta

CC:
chromium-reviews, amit, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Re-submit of GCF privacy patch in: http://codereview.chromium.org/858003 But this time with unittests that pass. BUG=22846 TEST=run unit tests, clear caches, see original CL for more details Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42712

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+355 lines, -100 lines)			Patch
M	chrome/browser/automation/automation_provider.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View		3 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/chrome_frame_automation_provider.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/test/automation/automation_messages_internal.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome_frame/bho.h	View		4 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome_frame/bho.rgs	View		1 chunk	+26 lines, -23 lines	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View		3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome_frame/chrome_frame_activex_base.h	View		4 chunks	+22 lines, -17 lines	0 comments	Download
M	chrome_frame/chrome_frame_automation.h	View		4 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome_frame/chrome_frame_automation.cc	View		10 chunks	+12 lines, -24 lines	0 comments	Download
M	chrome_frame/chrome_frame_npapi_unittest.cc	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome_frame/chrome_frame_plugin.h	View		5 chunks	+14 lines, -1 line	0 comments	Download
A	chrome_frame/delete_chrome_history.h	View	1 2	1 chunk	+65 lines, -0 lines	0 comments	Download
A	chrome_frame/delete_chrome_history.cc	View	1 2	1 chunk	+82 lines, -0 lines	0 comments	Download
M	chrome_frame/test/automation_client_mock.h	View		4 chunks	+9 lines, -7 lines	0 comments	Download
M	chrome_frame/test/automation_client_mock.cc	View		12 chunks	+21 lines, -12 lines	0 comments	Download
M	chrome_frame/test/chrome_frame_automation_mock.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome_frame/test/chrome_frame_test_utils.h	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome_frame/test/chrome_frame_test_utils.cc	View		3 chunks	+10 lines, -1 line	0 comments	Download
M	chrome_frame/utils.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome_frame/utils.cc	View		2 chunks	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ok

Expand Messages | Collapse Messages