Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: chrome/test/nacl/nacl_test.cc

Issue 1342002: Make nacl_ui_tests not flaky on Mac, enable the sandbox on Win64... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/nacl/nacl_test.h" 5 #include "chrome/test/nacl/nacl_test.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "chrome/common/chrome_paths.h" 8 #include "chrome/common/chrome_paths.h"
9 #include "chrome/common/chrome_switches.h" 9 #include "chrome/common/chrome_switches.h"
10 #include "chrome/test/automation/tab_proxy.h" 10 #include "chrome/test/automation/tab_proxy.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 FILE_PATH_LITERAL("server_test.html"); 53 FILE_PATH_LITERAL("server_test.html");
54 54
55 } // anonymous namespace 55 } // anonymous namespace
56 56
57 NaClTest::NaClTest() 57 NaClTest::NaClTest()
58 : UITest() { 58 : UITest() {
59 launch_arguments_.AppendSwitch(switches::kInternalNaCl); 59 launch_arguments_.AppendSwitch(switches::kInternalNaCl);
60 #if defined(OS_MACOSX) 60 #if defined(OS_MACOSX)
61 launch_arguments_.AppendSwitch(switches::kNoSandbox); 61 launch_arguments_.AppendSwitch(switches::kNoSandbox);
62 #endif 62 #endif
63
64 #if defined(OS_WIN)
65 if (NaClOsIs64BitWindows())
66 launch_arguments_.AppendSwitch(switches::kNoSandbox);
67 #endif
68 } 63 }
69 64
70 NaClTest::~NaClTest() {} 65 NaClTest::~NaClTest() {}
71 66
72 FilePath NaClTest::GetTestRootDir() { 67 FilePath NaClTest::GetTestRootDir() {
73 FilePath path; 68 FilePath path;
74 PathService::Get(base::DIR_SOURCE_ROOT, &path); 69 PathService::Get(base::DIR_SOURCE_ROOT, &path);
75 path = path.AppendASCII("native_client"); 70 path = path.AppendASCII("native_client");
76 path = path.AppendASCII("tests"); 71 path = path.AppendASCII("tests");
77 return path; 72 return path;
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 243
249 void NaClTest::TearDown() { 244 void NaClTest::TearDown() {
250 StopHttpServer(); 245 StopHttpServer();
251 UITest::TearDown(); 246 UITest::TearDown();
252 } 247 }
253 248
254 int NaClTest::NaClTestTimeout() { 249 int NaClTest::NaClTestTimeout() {
255 return std::max(kNaClTestTimeout, action_max_timeout_ms()); 250 return std::max(kNaClTestTimeout, action_max_timeout_ms());
256 } 251 }
257 252
258 #if defined(OS_MACOSX)
259 // http://code.google.com/p/nativeclient/issues/detail?id=342
260 TEST_F(NaClTest, FLAKY_ServerTest) {
261 #else
262 TEST_F(NaClTest, ServerTest) { 253 TEST_F(NaClTest, ServerTest) {
263 #endif
264 FilePath test_file(kServerHtmlFileName); 254 FilePath test_file(kServerHtmlFileName);
265 RunTest(test_file, NaClTestTimeout()); 255 RunTest(test_file, NaClTestTimeout());
266 } 256 }
267 257
268 #if defined(OS_MACOSX)
269 // http://code.google.com/p/nativeclient/issues/detail?id=342
270 TEST_F(NaClTest, FLAKY_SrpcHelloWorld) {
271 #else
272 TEST_F(NaClTest, SrpcHelloWorld) { 258 TEST_F(NaClTest, SrpcHelloWorld) {
273 #endif
274 FilePath test_file(kSrpcHwHtmlFileName); 259 FilePath test_file(kSrpcHwHtmlFileName);
275 RunTest(test_file, NaClTestTimeout()); 260 RunTest(test_file, NaClTestTimeout());
276 } 261 }
277 262
278 #if defined(OS_MACOSX)
279 // http://code.google.com/p/nativeclient/issues/detail?id=342
280 TEST_F(NaClTest, FLAKY_SrpcBasicTest) {
281 #else
282 TEST_F(NaClTest, SrpcBasicTest) { 263 TEST_F(NaClTest, SrpcBasicTest) {
283 #endif
284 FilePath test_file(kSrpcBasicHtmlFileName); 264 FilePath test_file(kSrpcBasicHtmlFileName);
285 RunTest(test_file, NaClTestTimeout()); 265 RunTest(test_file, NaClTestTimeout());
286 } 266 }
287 267
288 #if defined(OS_MACOSX)
289 // http://code.google.com/p/nativeclient/issues/detail?id=342
290 TEST_F(NaClTest, FLAKY_SrpcSockAddrTest) {
291 #else
292 TEST_F(NaClTest, SrpcSockAddrTest) { 268 TEST_F(NaClTest, SrpcSockAddrTest) {
293 #endif
294 FilePath test_file(kSrpcSockAddrHtmlFileName); 269 FilePath test_file(kSrpcSockAddrHtmlFileName);
295 RunTest(test_file, NaClTestTimeout()); 270 RunTest(test_file, NaClTestTimeout());
296 } 271 }
297 272
298 #if defined(OS_MACOSX)
299 // http://code.google.com/p/nativeclient/issues/detail?id=342
300 TEST_F(NaClTest, FLAKY_SrpcShmTest) {
301 #else
302 TEST_F(NaClTest, SrpcShmTest) { 273 TEST_F(NaClTest, SrpcShmTest) {
303 #endif
304 FilePath test_file(kSrpcShmHtmlFileName); 274 FilePath test_file(kSrpcShmHtmlFileName);
305 RunTest(test_file, NaClTestTimeout()); 275 RunTest(test_file, NaClTestTimeout());
306 } 276 }
307 277
308 #if defined(OS_MACOSX)
309 // http://code.google.com/p/nativeclient/issues/detail?id=342
310 TEST_F(NaClTest, FLAKY_SrpcPluginTest) {
311 #else
312 TEST_F(NaClTest, SrpcPluginTest) { 278 TEST_F(NaClTest, SrpcPluginTest) {
313 #endif
314 FilePath test_file(kSrpcPluginHtmlFileName); 279 FilePath test_file(kSrpcPluginHtmlFileName);
315 RunTest(test_file, NaClTestTimeout()); 280 RunTest(test_file, NaClTestTimeout());
316 } 281 }
317 282
318 #if defined(OS_MACOSX)
319 // http://code.google.com/p/nativeclient/issues/detail?id=342
320 TEST_F(NaClTest, FLAKY_SrpcNrdXferTest) {
321 #else
322 TEST_F(NaClTest, SrpcNrdXferTest) { 283 TEST_F(NaClTest, SrpcNrdXferTest) {
323 #endif
324 FilePath test_file(kSrpcNrdXferHtmlFileName); 284 FilePath test_file(kSrpcNrdXferHtmlFileName);
325 RunTest(test_file, NaClTestTimeout()); 285 RunTest(test_file, NaClTestTimeout());
326 } 286 }
OLDNEW
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698