Issue 1342001: Make errors and warnings a bit more obvious.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1342001: Make errors and warnings a bit more obvious. (Closed)

Created:
10 years, 9 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
robotboy, djmm

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Make errors and warnings a bit more obvious.

Patch Set 2 : Make the : line up. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/scripts/common.sh	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robotboy

http://codereview.chromium.org/1342001/diff/1/2 File src/scripts/common.sh (right): http://codereview.chromium.org/1342001/diff/1/2#newcode291 src/scripts/common.sh:291: echo -e "${V_BOLD_RED}ERROR: $1${V_VIDOFF}" Please add the ...'s to ...

10 years, 9 months ago (2010-03-25 17:56:10 UTC) #2

petkov

10 years, 9 months ago (2010-03-25 17:59:30 UTC) #3

LGTM, thanks.

Expand Messages | Collapse Messages

Issue 1342001: Make errors and warnings a bit more obvious. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Make the : line up. #

Messages