Issue 1338004: Add audioonly playground test. Move common things to dep.

Issue 1338004: Add audioonly playground test. Move common things to dep. (Closed)

Created:
10 years, 9 months ago by zhurunz

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, kmixter1, petkov, seano, ericli, sosa

Visibility:
Public.

Description

Add audioonly playground test. Move common things to dep.

Patch Set 2 : Add audioonly playground and remove common things to dep. #

Total comments: 7

Patch Set 3 : More improvement from codereview #

Patch Set 4 : More improvement from codereview. #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+172 lines, -51 lines)			Patch
M	client/deps/realtimecomm_playground/pgutil.py	View	1 2	2 chunks	+42 lines, -0 lines	0 comments	Download
A	client/site_tests/realtimecomm_GTalkAudioPlayground/control	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	client/site_tests/realtimecomm_GTalkAudioPlayground/options	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	client/site_tests/realtimecomm_GTalkAudioPlayground/realtimecomm_GTalkAudioPlayground.py	View	1 2	1 chunk	+80 lines, -0 lines	0 comments	Download
M	client/site_tests/realtimecomm_GTalkPlayground/realtimecomm_GTalkPlayground.py	View	1 2	4 chunks	+24 lines, -51 lines	0 comments	Download
M	client/site_tests/suite_HWQual/control.auto	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zhurunz

Add audioonly playground test. Move common things to dep.

10 years, 9 months ago (2010-03-25 23:49:20 UTC) #1

petkov

LGTM http://codereview.chromium.org/1338004/diff/2001/3001 File client/deps/realtimecomm_playground/pgutil.py (right): http://codereview.chromium.org/1338004/diff/2001/3001#newcode57 client/deps/realtimecomm_playground/pgutil.py:57: def setup_playground(src, des, optionfile): s/des/dst/ -- seems like ...

10 years, 9 months ago (2010-03-26 04:06:42 UTC) #2

zhurunz

10 years, 9 months ago (2010-03-26 18:03:16 UTC) #3

All done.

http://codereview.chromium.org/1338004/diff/2001/3001
File client/deps/realtimecomm_playground/pgutil.py (right):

http://codereview.chromium.org/1338004/diff/2001/3001#newcode57
client/deps/realtimecomm_playground/pgutil.py:57: def setup_playground(src, des,
optionfile):
On 2010/03/26 04:06:42, petkov wrote:
> s/des/dst/ -- seems like a more common abbreviation for destination

Done.

http://codereview.chromium.org/1338004/diff/2001/3004
File
client/site_tests/realtimecomm_GTalkAudioPlayground/realtimecomm_GTalkAudioPlayground.py
(right):

http://codereview.chromium.org/1338004/diff/2001/3004#newcode26
client/site_tests/realtimecomm_GTalkAudioPlayground/realtimecomm_GTalkAudioPlayground.py:26:
log = open(r'/tmp/tmp.log')
On 2010/03/26 04:06:42, petkov wrote:
> You should probably use utils.read_file instead.

Ah, that is handy.
Done.

http://codereview.chromium.org/1338004/diff/2001/3005
File
client/site_tests/realtimecomm_GTalkPlayground/realtimecomm_GTalkPlayground.py
(right):

http://codereview.chromium.org/1338004/diff/2001/3005#newcode19
client/site_tests/realtimecomm_GTalkPlayground/realtimecomm_GTalkPlayground.py:19:
self.job.setup_dep(['realtimecomm_playground'])
On 2010/03/26 04:06:42, petkov wrote:
> Use self.dep instead?
> 

Done.

Expand Messages | Collapse Messages