Issue 13375: Fix incorrect pattern offsets, and rebaseline associated test results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13375: Fix incorrect pattern offsets, and rebaseline associated test results. (Closed)

Created:
12 years ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
brettw, agl

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix incorrect pattern offsets, and rebaseline associated test results. This now performs a similar origin translation as ImageCG.cpp, which seems to work, though it also seems to imply a relationship between the src and dest rects which I haven't found explicitly documented or enforced anywhere.

Patch Set 1 #

Patch Set 2 : New fix plus rebaselines #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, --1 lines)			Patch
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/repeat/negative-offset-repeat-expected.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/size/backgroundSize18-expected.checksum	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/size/backgroundSize18-expected.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/size/zero-expected.checksum	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/backgrounds/size/zero-expected.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-rotate-transform-expected.checksum	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/borders/border-image-rotate-transform-expected.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/canvas/canvas-bg-expected.checksum	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/canvas/canvas-bg-expected.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/border-image-01-expected.checksum	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/border-image-01-expected.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/border-image-rotate-transform-expected.checksum	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/border-image-rotate-transform-expected.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/border-image-scale-transform-expected.checksum	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/borders/border-image-scale-transform-expected.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-expected.checksum	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-expected.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-expected.txt	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/gradients/border-image-gradient-sides-and-corners-expected.txt	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	webkit/port/platform/graphics/skia/ImageSkia.cpp	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	webkit/tools/layout_tests/test_lists/tests_fixable.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Moss

I found that there is indeed a problem ignoring phase. In particular, it messes up ...

12 years ago (2008-12-12 21:00:32 UTC) #2

LGTM

Expand Messages | Collapse Messages